Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles 2.1 support in Spring 3.0 is not compatible with Tomcat 5.5 [SPR-6309] #10975

Closed
spring-projects-issues opened this issue Nov 5, 2009 · 3 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Matt Goldspink opened SPR-6309 and commented

We have some users who tried to upgrade to Spring 3.0.RC1 but could not because they were using Spring MVC with tiles. Unfortunately since Tiles 2.1.x they have added a dependency on the Tomcat 6:

References for the conclusion we came to are:

http://issues.apache.org/struts/browse/TILES-268, http://issues.apache.org/struts/browse/TILES-447 and http://svn.apache.org/viewvc?view=revision&revision=798098

We do not have Tomcat 6.x in our firms environment and it will not be ready for about 6 months due to other on going priorities. We would really like to let all our users use Spring 3.0 but this is issue is unfortunately a blocker for those guys and we've not yet found workaround.


Affects: 3.0 RC1

Referenced from: commits 4e23304

1 votes, 2 watchers

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

There was indeed a problem with default Tiles 2.1 setup in Spring expecting EL support to be present, which it only is in JSP 2.1 but not in JSP 2.0. We've fixed this for the upcoming Spring 3.0 RC2: TilesConfigurer only sets up EL support if JSP 2.1 is present at runtime now, making Spring's Tiles 2.1 support compatible with JSP 2.0 out of the box.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Note that Spring 3.0 still requires Tiles 2.1.2 or above; it should just be compatible with JSP 2.0 out of the box now. When running on Tomcat 6.0, EL support will be activated by default; when running on Tomcat 5.5, it should simply be turned off by default now, not causing any compatibility issues.

I've adapted the title of this JIRA issue accordingly, reflecting the focus on Tomcat 5.5 compatibility rather than Tiles 2.0 support.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Matt Goldspink commented

This is great Jeurgen. Thanks very much for the swift response. Could you let me know if there's a nightly build of this we should try and I can get our users to test and verify everything's good for them.

Matt

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 RC2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants