@RequestMapping handled incorrectly when value contains "." (dot) character [SPR-6482]

[spring-projects-issues]

Aleš Najmann opened SPR-6482 and commented

At the moment in my code exist method with such signature:

@RequestMapping(value = "/projects/{filter}/{order}-{direction}", method = RequestMethod.GET)
public String filteredProjectListing(@PathVariable("filter") String filter, @PathVariable("order") String order,
            @PathVariable("direction") String direction, ModelMap model) {
 ...
}

order is String variable containing ognl-like expresssion ie. "raging.result" (which I later use for BeanComparator) but this mapping is in version RC3 is not found, which is different behaviour from RC2 where there is no such problem.

Log message with example of given fault result is:

2009-12-01 16:38:02,459 WARN [org.springframework.web.servlet.PageNotFound] - <No mapping found for HTTP request with URI [/Example/projects/all/rate.result-asc.html] in DispatcherServlet with name 'Example'>

There is no problem with handling path which doesn't contain more '.' (dot) characters, so this can probably help you with analysis of the problem.

---

Affects: 3.0 RC3

Attachments:

• UriTemplateServletAnnotationControllerTests.java.diff (1.41 kB)

Issue Links:

• Requests URIs containing . cannot be mapped correctly using @RequestMapping in RC3 [SPR-6560] #11226 Requests URIs containing . cannot be mapped correctly using @RequestMapping in RC3 ("is duplicated by")
• @MVC URI Template Variable Regression - Matching values containing . (dot) [SPR-6499] #11165 @MVC URI Template Variable Regression - Matching values containing . (dot) ("is duplicated by")
• PathVariable resolution does not work properly [SPR-6280] #10947 PathVariable resolution does not work properly

Referenced from: commits 976f920

1 votes, 3 watchers

[spring-projects-issues]

Grzegorz Borkowski commented

We have the same problem. After switching to RC3, some code stopped working, throwing "no mapping found for HTTP request".

[spring-projects-issues]

Scott Andrews commented

Unit test for UriTemplateServletAnnotationControllerTests.java that demonstrates this issue.

Changing the mapping to include an explicit regex allows the test to path, but is not ideal.

For example:
@RequestMapping("/hotels/{hotel:.*}/bookings")

[spring-projects-issues]

Arjen Poutsma commented

This regression was due to a matching change made as fix for #10947. I've reverted that behavior, so things should work now.

Could you please try a upcoming snapshot and see if it is fixed?

[spring-projects-issues]

Christopher Anderson commented

Excellent, will try tonight's build tomorrow.

[spring-projects-issues]

Christopher Anderson commented

That worked. Thanks

[spring-projects-issues]

Kirk Larsen commented

test

[spring-projects-issues]

Christanto commented

The issue still happens in 3.0.5.
"abc.xyz" will be returned as "abc".

[spring-projects-issues]

Christanto commented

Sorry I think you can close this as this issue is actually reported in #10832.