Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimeFormatAnnotationFormatterFactory calls String.isEmpty(), which exists only in JDK1.6+ [SPR-6529] #11195

Closed
spring-projects-issues opened this issue Dec 7, 2009 · 2 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Dec 7, 2009

Marty Jones opened SPR-6529 and commented

This issue has already been raised (#11061) but was closed as a duplicate and was marked as fixed in RC3. I looked at the source and as you can see from this snippet that the isEmpty call is still there.

private DateTimeFormatter configureDateTimeFormatterFrom(DateTimeFormat annotation) {
	if (!annotation.pattern().isEmpty()) {
			return forPattern(annotation.pattern());
	}
	else if (annotation.iso() != ISO.NONE) {
		return forIso(annotation.iso());
	}
	else {
		return forStyle(annotation.style());
	}
}

Affects: 3.0 RC3

Referenced from: commits 231c833

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

This should really be fixed now, also in NumberFormatAnnotationFormatFactory.

@spring-projects-issues
Copy link
Collaborator Author

Marty Jones commented

Arjen,

Do you know when 3.0 GA is planning on being released?

@spring-projects-issues spring-projects-issues added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 GA milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants