Regression in @RequestMapping parsing path variable in the url [SPR-6532]

[spring-projects-issues]

Youen Chéné opened SPR-6532 and commented

Hi i've got the this spring mvc code which works fines with RC2.

@RequestMapping(value={"/product-{id}.html","/product-{id}-{name}.html"})
public String showProduct(@PathVariable String id,@RequestParam(value="loc",required=false) String location,Model model)

When I am switching with RC3, it is only handle the /product-{id}.html url pattern and not the /product-{id}-{name}.html pattern. In fact with this last pattern it try to put {id}-{name} in the id path variable instead of just put {id}.

Sorry, if it is a duplicate, after a quick looking it dot not seems to be one.

---

Affects: 3.0 RC3

[spring-projects-issues]

Arjen Poutsma commented

What kind of HTTP requests are to be handled by this controller? I'm guessing something like /product-foo and /product-foo-bar, but I'd like to be sure. Are there .'s (periods) in the request?

[spring-projects-issues]

Arjen Poutsma commented

In RC3, we changed the way patterns are compared to figure out the best match. In RC2 and before, it used to be based on pattern length, but that resulted in strange behavior (see #10947).

From RC3, it's based on the amount of variables and wildcards used: the pattern with the least amount of wildcards wins. For a request like /product-1-2.html, that is /product-{id}.html. You can even see that in the log:

DefaultAnnotationHandlerMapping - Matching patterns for request [/product-5-6.html] are [/product-{id}.html, /product-{id}-{name}.html]

this logging statement shows all matches, in best matching order.

The way to fix your issue is to make sure that the {id} variable does not match dashes (-'s). You can do that by changing the regular expression for the mapping, like this:

@RequestMapping(value={"/product-{id:[^-]+}.html","/product-{id}-{name}.html"})
public String showProduct(@PathVariable String id,@RequestParam(value="loc",required=false) String location,Model model)

Then your code works fine (or at least in my tests).

On a related note: why are you using that {name} variable when you don't use it? I think /product-{id}-*.html would work for you as well.

[spring-projects-issues]

Arjen Poutsma commented

Reopening because of faulty resolution.

[spring-projects-issues]

Youen Chéné commented

Hi,

Thanks for the quick "how to". This explanation should be in the docs as example of handling path elements.

I'll test it tomorrow.

Thanks

PS: I've a big week and I don't understand why I missed the email notification?