Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JdbcTemplate.newArgPreparedStatementSetter should return PreparedStatementSetter [SPR-6897] #11562

Closed
spring-projects-issues opened this issue Feb 23, 2010 · 1 comment
Closed

JdbcTemplate.newArgPreparedStatementSetter should return PreparedStatementSetter [SPR-6897] #11562

spring-projects-issues opened this issue Feb 23, 2010 · 1 comment
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task
Milestone
3.0.2

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Feb 23, 2010 •
edited
Loading

Stepan Koltsov opened SPR-6897 and commented

JdbcTemplate.newArgPreparedStatementSetter should return PreparedStatementSetter, currently it returns concrete class ArgPreparedStatementSetter. This change is be backward-compatible, since ArgPreparedStatementSetter class is package-protected, and it is unlikely that somebody has overridden the method.

Related to #8657.

Affects: 3.0.1

Referenced from: commits 4bda92f
@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Fixed for 3.0.2. Should also be backwards-compatible since overridden methods would simply narrow the return type (which they may do in Java 5 and above).

Juergen

@spring-projects-issues spring-projects-issues added in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task
Projects
None yet
Milestone
3.0.2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues