Skip to content

MockHttpServletRequest must not throw an exception on getParameter(null) [SPR-10192] #14825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jan 18, 2013 · 0 comments
Assignees
Labels
in: test Issues in the test module status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Oliver Drotbohm opened SPR-10192 and commented

The JavaDoc of ServletRequest does not specify the parameter name to be a non-null value. So we have to deal with clients calling the method with a null value leniently and simply return null.

Servlet containers like Jetty are not as strict and thus one might stumble over this issue only when using e.g. Spring MVC testing framework.


Issue Links:

  • DATAREST-60 AbstractRepositoryRestController potentially calls HttpServletRequest.getParameter(…) with null

Referenced from: commits c1a4f5c, 01f3102

Backported to: 3.1.4

@spring-projects-issues spring-projects-issues added type: bug A general bug in: test Issues in the test module status: backported An issue that has been backported to maintenance branches labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.2.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants