Unit test in EvalTagTests fails with French as default locale [SPR-11392]

[spring-projects-issues]

Sébastien Deleuze opened SPR-11392 and commented

The testPrintFormattedScopedAttributeResult() test method from org.springframework.web.servlet.tags.EvalTagTests is locale dependent.

When I built Spring from sources with French locale, this test failed. When I switched to English locale, it passed.

The current assertion is hard coded ("25%"). I think it should take into account the default locale in order to have the test pass regardless of the default locale of the computer running the tests. In my case it is "25%" with English locale and "25 %" with French locale.

---

Affects: 3.2.7, 4.0.1

Backported to: 3.2.8

[spring-projects-issues]

Sam Brannen commented

Hi Sébastien,

I've merged this into master: edb0b0e

Though I'm not sure if it warrants a backport to 3.2.x. So I'll leave this issue open until you clarify that.

Regards,

Sam

[spring-projects-issues]

Sébastien Deleuze commented

Thanks for merging Sam. We should backport this to 3.2.x too, I double checked with Juergen Hoeller.

[spring-projects-issues]

Sam Brannen commented

OK. I'll take care of the backport.

[spring-projects-issues]

Sam Brannen commented

This has now been backported to 3.2.x: a2ec8f8

[spring-projects-issues]

Sam Brannen commented

Resolving this issue as complete since it has been pushed to both the master (4.0.2) and 3.2.x (3.2.8) branches. See previous comments for links and further details.