Skip to content

MarshallingView should explicitly skip BindingResult when searching for a model object [SPR-11417] #16044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Feb 11, 2014 · 1 comment
Assignees
Labels
status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Juergen Hoeller opened SPR-11417 and commented

A couple of custom MarshallingView extensions do the very same thing: They explicitly skip BindingResult when searching for a model object.

http://syspeak.googlecode.com/svn/trunk/SysPeak/apps/MakerEAP/workflow/src/main/java/com/syspeak/modules/spring/web/servlet/view/xml/FilterMarshallingView.java
http://my-channel-web.googlecode.com/svn/trunk/my-channel-web/src/com/winxuan/channel/support/view/xml/IgnoreBindingMarshalingView.java
http://www.cnblogs.com/hoojo/archive/2011/04/29/2032609.html

There seems to be nothing wrong with doing that out of the box, since it's unlikely that somebody intends to render a BindingResult as XML...


Affects: 3.2.7, 4.0.1

Referenced from: commits 6f58491, b223e6e

Backported to: 3.2.8

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Fixed now through an explicit BindingResult check, but only for multi-element model Maps. If the only element we have is a BindingResult, we'll still pass it on the Marshaller... just in case.

Juergen

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants