Skip to content

JmsMessagingTemplate should not throw JmsException directly [SPR-12038] #16654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jul 28, 2014 · 2 comments
Assignees
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jul 28, 2014

Stéphane Nicoll opened SPR-12038 and commented

Consider a review of JmsMessagingTemplate to translate any JmsException to a standard MessagingException that encapsulates the lower level exception.

Right now, plain JmsException instances are thrown.


Affects: 4.1 RC1

Issue Links:

Referenced from: commits 1fe742a, 89d63eb, c06ac06

@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

Added MessagingExceptionTranslator with a JMS implementation that is used behind the scenes by JmsMessagingTemplate.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Aug 9, 2014

Juergen Hoeller commented

As per my comment on #16680, JmsMessagingTemplate delegates to a local convertJmsException template method for those purposes now, giving us the chance to avoid a generic MessagingExceptionTranslator for the time being and potentially reconsider it for a different role at a later point.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants