Skip to content

Include Groovy source code in published sources jars [SPR-12086] #16702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
spring-projects-issues opened this issue Aug 15, 2014 · 3 comments
Closed
1 task done
Assignees
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 15, 2014

Sam Brannen opened SPR-12086 and commented

Status Quo

#16701 updated the Gradle build to ensure that all source artifacts are included in published 'sources' jars; however, the work fell short of incorporating Groovy source code (i.e., '**/*.groovy') into the 'sources' jars.

Deliverables

  1. Ensure that Groovy source code (e.g., GroovyDynamicElementReader.groovy from the spring-beans module) is included in the published 'sources' jars

Affects: 4.0.6, 4.1 RC2

Issue Links:

Referenced from: commits 042cfee

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Fixed as described in the comments for GitHub commit 042cfee:

Include Groovy source code in published sources jars

In our Gradle build script, we are now assembling 'sources' jars from
'sourceSets.main.allSource' in order to include Java, Groovy, and
AspectJ source code as well all other appropriate classpath resources.

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Reopened for backporting.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Aug 26, 2014

Sam Brannen commented

This has been superseded by the updated scope of #16701.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants