Duplicated interceptors in HandlerExecutionChain after intermediate getInterceptors() call [SPR-12566]

[spring-projects-issues]

Juraj Bak opened SPR-12566 and commented

Method HandlerExecutionChain.initInterceptorList() duplicates interceptor records if attribute interceptorList contains previously added items resulting into duplicated interceptor calls.

Simple fix is to add this.interceptorList.clear() or initialize new Instance of list before line 104.
this.interceptorList.addAll(Arrays.asList(this.interceptors));
See attached source and test.

Btw. Is there a reason for convertion between collection and array? Class AbstractHandlerMapping works with collections, also a HandlerExecutionChain do so internally. But interface uses arrays and forces everybody to convert collections to arrays and back.

---

Affects: 3.2.12, 4.1.3

Attachments:

• HandlerExecutionChain.java (6.66 kB)
• HandlerExecutionChainTest.java (1.09 kB)

Referenced from: commits e353af6, 37713ae, 6b3023c

Backported to: 4.0.9, 3.2.13

[spring-projects-issues]

Juergen Hoeller commented

The parallel handling of an array and a List there is primarily historical. I don't see a strong need to change this though (with this issue here fixed).

Juergen

[spring-projects-issues]

Juergen Hoeller commented

It's worth mentioning that this only happens with an intermediate {{getInterceptors()} call... The old implementation assumed that such a call would only come as a terminal operation at the very end. The revised implementation allows for such calls to happen at any point now.

Juergen