Skip to content

Close processing triggered by shutdown hook isn't thread safe [SPR-13556] #18132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 9, 2015 · 0 comments
Closed

Close processing triggered by shutdown hook isn't thread safe [SPR-13556] #18132

spring-projects-issues opened this issue Oct 9, 2015 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
4.2.2

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 9, 2015 •
edited
Loading

Andy Wilkinson opened SPR-13556 and commented

In AbstractApplicationContext, refresh and close both synchronize on startupShutdownMonitor to prevent concurrent processing. However, when the application context's shutdown hook is performing the close processing this doesn't hold true as it doesn't synchronise on startupShutdownMonitor. This means it's possible for two close calls or a close and a refresh to occur in parallel.

Affects: 4.1.7

Reference URL: spring-projects/spring-boot#4130

Issue Links:

Referenced from: commits 92dc51f, 57125c0

Backported to: 4.1.8
@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.2.2 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
4.2.2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues