Avoid JNDI property lookup attempts for invalid JNDI keys [SPR-14518]

[spring-projects-issues]

Juergen Hoeller opened SPR-14518 and commented

As indicated by spring-projects/spring-boot#6460, when running in a Servlet environment, Spring tries to resolve property names in JNDI (even if they are typically not actually found there). The performance impact of this has been raised in #18598 already, leading to the introduction of the "spring.jndi.ignore" property in 4.3. However, even with that option around, it still seems wasteful to try a JNDI lookup for property keys which are clearly invalid in JNDI's naming scheme. We should try to bypass JNDI lookups for such keys by default.

---

Affects: 4.2.7, 4.3.1

Referenced from: commits 328e04f, 7021a4b, 4e94e84

Backported to: 4.2.8

[spring-projects-issues]

Juergen Hoeller commented

As of 4.3.2, JndiPropertySource defensively skips property names containing a colon when in resource-ref mode (which is the default) since they are effectively never valid and will never get prefixed with the intended "java:comp/env" either.

Aside from avoiding misleading warnings in server logs (like on Liberty), this also has a positive performance impact since it cuts the number of JNDI lookup attempts to half (the variants including the default clause will always get skipped, just the regular ones processed).

In non-resource-ref mode, we'll keep processing any given property name in JNDI since it is meant to contain a prefix anyway in that mode.