Spring MVC 4.3.5's Jackson auto-configuration breaks against Jackson 2.3.3 on the classpath [SPR-15051]

[spring-projects-issues]

Jim Richards opened SPR-15051 and commented

When I run my servlet with Spring 4.3.4.RELEASE there are no issues. When I update to 4.3.5.RELEASE I get this error on startup

Dec 24, 2016 7:50:04 PM org.apache.catalina.core.StandardContext listenerStart
SEVERE: Exception sending context initialized event to listener instance of class org.springframework.web.context.ContextLoaderListener
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter': Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter]: Constructor threw exception; nested exception is java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/util/DefaultIndenter
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1116)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1060)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:513)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:759)
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
	at org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:444)
	at org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:326)
	at org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107)
	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4842)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5303)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1407)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1397)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter]: Constructor threw exception; nested exception is java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/util/DefaultIndenter
	at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:154)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:89)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateBean(AbstractAutowireCapableBeanFactory.java:1108)
	... 22 more
Caused by: java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/util/DefaultIndenter
	at org.springframework.http.converter.json.AbstractJackson2HttpMessageConverter.init(AbstractJackson2HttpMessageConverter.java:97)
	at org.springframework.http.converter.json.AbstractJackson2HttpMessageConverter.<init>(AbstractJackson2HttpMessageConverter.java:90)
	at org.springframework.http.converter.json.MappingJackson2HttpMessageConverter.<init>(MappingJackson2HttpMessageConverter.java:66)
	at org.springframework.http.converter.json.MappingJackson2HttpMessageConverter.<init>(MappingJackson2HttpMessageConverter.java:57)
	at org.springframework.http.converter.support.AllEncompassingFormHttpMessageConverter.<init>(AllEncompassingFormHttpMessageConverter.java:61)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.<init>(RequestMappingHandlerAdapter.java:182)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:142)
	... 24 more
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.util.DefaultIndenter
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1332)
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1166)
	... 35 more

which is resolved by adding

<dependency>
    <groupId>com.fasterxml.jackson.core</groupId>
    <artifactId>jackson-core</artifactId>
    <version>2.8.5</version>
</dependency>

to pom.xml.

I note that in

• https://spring.io/blog/2016/06/10/spring-framework-4-3-goes-ga

it mentions that

Spring 4.3’s Jackson support requires Jackson 2.6+ now.

Is this related?

---

Issue Links:

• sse breaks with indenting serializer [SPR-14899] #19465 sse breaks with indenting serializer
• Require Jackson 2.6+, FreeMarker 2.3.21+, XStream 1.4.5+ [SPR-13062] #17654 Require Jackson 2.6+, FreeMarker 2.3.21+, XStream 1.4.5+

[spring-projects-issues]

Juergen Hoeller commented

Even if Jackson is a very common dependency, such a hard requirement wasn't intentional. We'll fix it for 4.3.6.

That said, it's unclear why this would be a regression in 4.3.5 specifically. The registration code there checks for the presence of Jackson classes in the classpath, and hasn't changed in a while.

Have you possibly had an incomplete arrangement of Jackson jars on the classpath, with just jackson-core missing?

[spring-projects-issues]

Jim Richards commented

Have you possibly had an incomplete arrangement of Jackson jars on the classpath, with just jackson-core missing?

Most likely it's this dependency

<dependency>
	<groupId>org.springframework.social</groupId>
	<artifactId>spring-social-google</artifactId>
	<version>1.0.0.RELEASE</version>
</dependency>

as it pulls in Jackson 2.3.3 which was probably enough before, but something in 4.3.5.RELEASE then required the newer version.

[spring-projects-issues]

Juergen Hoeller commented

This looks like a side effect of #19465 where the fix started using the Jackson 2.5+ DefaultIndenter class. Since we have a Jackson 2.6+ baseline now, as you pointed out, this is entirely valid... The ability to use such newer classes is why we raised the baseline to begin with.

So I'm afraid this is by design from the core Spring Framework perspective: We do not require Jackson as a dependency, but if you have it on the classpath, it needs to be 2.6 or higher now.

Since Spring Social Google is a community project, please report it to its issue tracker on GitHub:
https://github.com/GabiAxel/spring-social-google/issues

[spring-projects-issues]

Jim Richards commented

Issue with spring-social-google is logged here

• Update Jackson to 2.6+ to be compatible with Spring 4.3.5 spring-social/spring-social-google#95