Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTag renders empty <div> tag [SPR-16498] #21041

Closed
spring-projects-issues opened this issue Feb 14, 2018 · 1 comment
Closed

FormTag renders empty <div> tag [SPR-16498] #21041

spring-projects-issues opened this issue Feb 14, 2018 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Delete this account opened SPR-16498 and commented

The doEndTag method in org/springframework/web/servlet/tags/form/FormTag.java uses writeHiddenFields to write the ExtraHiddenFields to a <div> tag. The if statement inside writeHiddenFields checks for hiddenFields being null, but in the case of it being an empty Map will write an empty <div></div> at the end of the <form>.

Possible solutions:

  • remove encapsulating <div>, possible hidden inputs would be direct children of the <form> tag
  • check hiddenFields not only for null but also for empty keyset in the if condition

Affects: 4.3.14

Referenced from: commits 350f318, 6d75732

Backported to: 4.3.15

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point, we're simply checking CollectionUtils.isEmpty there now. To be backported to 4.3.15.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.0.4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants