Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent volatile access to running flag in Lifecycle implementations [SPR-16596] #21137

Closed
spring-projects-issues opened this issue Mar 15, 2018 · 0 comments
Closed

Consistent volatile access to running flag in Lifecycle implementations [SPR-16596] #21137

spring-projects-issues opened this issue Mar 15, 2018 · 0 comments
Assignees
@jhoeller
Labels
status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.0.5

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 15, 2018 •
edited
Loading

Juergen Hoeller opened SPR-16596 and commented

As #21031 revealed, several of our Lifecycle implementations enforce overly strong locks, in particular in their isRunning() implementations. As we do in a many places already, running should be a volatile flag that can be checked outside of any lifecycle monitor.

Affects: 4.3.14, 5.0.4

Issue Links:

Referenced from: commits b8c92ce

Backported to: 4.3.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.5
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues