Use doOnDiscard to free internally queued data buffers [SPR-17246]

[spring-projects-issues]

Arjen Poutsma opened SPR-17246 and commented

We should leverage the upcoming Reactor core feature onDiscardQueueWithClear to free the internally queued DataBuffer instances when the publisher is cancelled or terminated on an error (see reactor core pr #1155).

This issue was initially part of #21563.

---

Issue Links:

• DataBufferUtils#join could leak buffers in case of error from the source [SPR-17025] #21563 DataBufferUtils#join could leak buffers in case of error from the source
• Review DataBuffer handling code for proper release in case of error or cancellation [SPR-17408] #21941 Review DataBuffer handling code for proper release in case of error or cancellation

Referenced from: commits 8a48353

[spring-projects-issues]

Arjen Poutsma commented

See reactor/reactor-core@0dc8be2 for a more recent version of the discard hook.

[spring-projects-issues]

Arjen Poutsma commented

Implemented in 8a48353

[spring-projects-issues]

Rossen Stoyanchev commented

Arjen Poutsma, shouldn't we be doing this on all the other places where expose Flux<DataBuffer> from Reactor and Undertow, i.e. in ClientHttpResponse#getBody() and WebSocketSession#receive()?