Skip to content

Comparators.nullsLow creates wrong kind of NullSafeComparator [SPR-17357] #21891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 9, 2018 · 0 comments
Closed

Comparators.nullsLow creates wrong kind of NullSafeComparator [SPR-17357] #21891

spring-projects-issues opened this issue Oct 9, 2018 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.1.1

Comments

@spring-projects-issues
Copy link
Collaborator

Juergen Hoeller opened SPR-17357 and commented

Due to a typo, Comparators.nullsLow passes in false into NullSafeComparator's nullsLow argument. This has been fixed through PR 1982 on master but needs to be backported to 5.0.10 as well, tracking the fix through this JIRA issue now.

Affects: 5.0.9, 5.1 GA

Referenced from: pull request #1982, and commits 8d1499e

Backported to: 5.0.10
@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.1 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues