Skip to content

Review DataBufferUtils [SPR-17411] #21944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Oct 19, 2018 · 2 comments
Closed

Review DataBufferUtils [SPR-17411] #21944

spring-projects-issues opened this issue Oct 19, 2018 · 2 comments
Assignees
@poutsma
Labels
type: task A general task
Milestone
5.1.2

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 19, 2018 •
edited
Loading

Arjen Poutsma opened SPR-17411 and commented

DataBufferUtils should handle both error and cancellation signals. Currently join does error only, while readByteChannel and readAsynchronousFileChannel do onDiscard which does both. Other methods like takeUntil to be reviewed.

This issue is a sub-task of #21941
@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed in 149d416

@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

One more: 488a1d4

@spring-projects-issues spring-projects-issues added the type: task A general task label Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.2 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
type: task A general task
Projects
None yet
Milestone
5.1.2
Development

No branches or pull requests
2 participants
@poutsma @spring-projects-issues