Skip to content

ForwardedHeaderTransformer double encodes [SPR-17525] #22057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 21, 2018 · 2 comments
Closed

ForwardedHeaderTransformer double encodes [SPR-17525] #22057

spring-projects-issues opened this issue Nov 21, 2018 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.1.3

Comments

@spring-projects-issues
Copy link
Collaborator

Ryosuke Hasebe opened SPR-17525 and commented

Version: 5.1.2 RELEASE

The UriComponentsBuilder encodes the already encoded query parameter again.
Please check. :)

https://github.com/spring-projects/spring-framework/blob/master/spring-web/src/main/java/org/springframework/web/server/adapter/ForwardedHeaderTransformer.java#L88

Affects: 5.1.2

Backported to: 5.0.11
@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

Thanks for the report.

@spring-projects-issues
Copy link
Collaborator Author

Ryosuke Hasebe commented

Thanks.

@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.3 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.1.3
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues