Skip to content

ResourceUrlEncodingFilter versioning breaks when URL contains fragment [SPR-17535] #22067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 23, 2018 · 1 comment
Closed

ResourceUrlEncodingFilter versioning breaks when URL contains fragment [SPR-17535] #22067

spring-projects-issues opened this issue Nov 23, 2018 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.1.3

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 23, 2018 •
edited
Loading

Ondřej Kraus opened SPR-17535 and commented

resolveUrlPath in ResourceUrlEncodingRequestWrapper in ResourceUrlEncodingFilter checks for query string, but not for fragment. This breaks versioning when URLs with fragment are used (tested with Thymeleaf):

th:src="@{/assets/images/icons/sprite.svg#face1}"

does not add version. Replacing getQueryParamsIndex with something that checks for both question mark and hash mark fixes it.

Affects: 5.1.2

Issue Links:

Referenced from: pull request #2025, and commits 959cf61, 029101c
@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.3 milestone Jan 11, 2019
Closed
@arne-vandamme
Copy link

arne-vandamme commented Feb 15, 2019 •
edited
Loading

@rstoyanchev We are running into the same issue with 4.3.x, is there any chance to backport the fix?

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-4.3.x labels Mar 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.3
Development

No branches or pull requests
3 participants
@rstoyanchev @arne-vandamme @spring-projects-issues