Skip to content

TomcatHttpHandlerAdapter is not aware of Server[Request|Response]Wrapper [SPR-17611] #22143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Dec 19, 2018 · 1 comment
Closed

TomcatHttpHandlerAdapter is not aware of Server[Request|Response]Wrapper [SPR-17611] #22143

spring-projects-issues opened this issue Dec 19, 2018 · 1 comment
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone
5.1.4

Comments

@spring-projects-issues
Copy link
Collaborator

Arjen Poutsma opened SPR-17611 and commented

In TomcatServerHttpRequest#createTomcatHttpHeaders, it is assumed that the given HttpServletRequest is a org.apache.catalina.connector.RequestFacade, while it could be a HttpServletRequestWrapper. Similarly, TomcatServerHttpResponse#createTomcatHttpHeaders assumes that the given response is a ResponseFacade, while it could be a HttpServletResponseWrapper.

Affects: 5.1.3

Reference URL: spring-projects/spring-boot#15489

Referenced from: commits 5e4a896
@spring-projects-issues
Copy link
Collaborator Author

Arjen Poutsma commented

Fixed in 5e4a896

@spring-projects-issues spring-projects-issues added type: bug A general bug in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.4 milestone Jan 11, 2019
@migedt migedt mentioned this issue Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Milestone
5.1.4
Development

No branches or pull requests
2 participants
@poutsma @spring-projects-issues