Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently implement decodeToMono by joining buffers first #22783

Closed
rstoyanchev opened this issue Apr 10, 2019 · 0 comments
Closed

Consistently implement decodeToMono by joining buffers first #22783

rstoyanchev opened this issue Apr 10, 2019 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.2 M2

Comments

@rstoyanchev
Copy link
Contributor

Many decoders extend AbstractDataBufferDecoder that implements decodeToMono by joining buffers and then delegating to sub-classes to decode a single DataBuffer. All decoders should do that consistently.

Protobuf does not extend this class but practically does the same so it can be refactored. Jackson and Jaxb2 could be changed to do this too instead of asynchronous parsing.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Apr 10, 2019
@rstoyanchev rstoyanchev added this to the 5.2 M2 milestone Apr 10, 2019
@rstoyanchev rstoyanchev self-assigned this Apr 10, 2019
@rstoyanchev rstoyanchev mentioned this issue Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M2
Development

No branches or pull requests
1 participant
@rstoyanchev