Skip to content

Wiki build instructions for local Maven repo are outdated #23517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlawrynowicz opened this issue Aug 25, 2019 · 2 comments
Closed

Wiki build instructions for local Maven repo are outdated #23517

jlawrynowicz opened this issue Aug 25, 2019 · 2 comments
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@jlawrynowicz
Copy link

Affects: project wiki / 5.2.0.BUILD-SNAPSHOT


Commit 7ce1f5e (related to #23282) changes gradle task used for pushing artifacts to local maven repository, making instructions on project wiki obsolete:

https://github.com/spring-projects/spring-framework/wiki/Build-from-Source

./gradlew install -x javadoc

results in Task 'install' not found in root project 'spring'. error. Correct comand is:

./gradlew publishToMavenLocal -x javadoc

This change is not compatible with branches 5.1.x and earlier, so perhaps wiki article should be expanded to reflect that or install task should be restored to preserve old behavior.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 25, 2019
@sbrannen
Copy link
Member

Thanks for bringing this to our attention.

Since the wiki is not tied to master or any particular branch, we will in fact need to update the wiki accordingly.

@sbrannen sbrannen added this to the 5.2 RC2 milestone Aug 26, 2019
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 26, 2019
@sbrannen sbrannen self-assigned this Aug 27, 2019
@sbrannen
Copy link
Member

@sbrannen sbrannen changed the title wiki build instructions out of date Wiki build instructions for local Maven repo are out of date Aug 27, 2019
@sbrannen sbrannen changed the title Wiki build instructions for local Maven repo are out of date Wiki build instructions for local Maven repo are outdates Aug 27, 2019
@sbrannen sbrannen changed the title Wiki build instructions for local Maven repo are outdates Wiki build instructions for local Maven repo are outdated Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

3 participants