Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document support of Vavr's Try to potentially roll back declarative transactions #29560

Closed
odrotbohm opened this issue Nov 23, 2022 · 1 comment · Fixed by #30108
Closed

Document support of Vavr's Try to potentially roll back declarative transactions #29560

odrotbohm opened this issue Nov 23, 2022 · 1 comment · Fixed by #30108
Assignees
@jhoeller
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: documentation A documentation task

Comments

@odrotbohm
Copy link
Member

odrotbohm commented Nov 23, 2022 •
edited by sbrannen
Loading

#20361 introduced support for Vavr's Try monad to trigger transaction rollbacks when an @Transactional-annotated method returns a Failure.

I would appreciate it if that feature was described in the reference documentation, likely this section.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 23, 2022
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: documentation A documentation task labels Nov 23, 2022
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 23, 2022
@sbrannen sbrannen added this to the 6.0.x milestone Nov 23, 2022
@jhoeller jhoeller assigned jhoeller and unassigned odrotbohm Mar 7, 2023
@jhoeller jhoeller modified the milestones: 6.0.x, 6.1.x Mar 7, 2023
@edyda99 edyda99 mentioned this issue Mar 12, 2023
Merged
@jhoeller jhoeller added the status: superseded An issue that has been superseded by another label Mar 21, 2023
@jhoeller jhoeller removed this from the 6.1.x milestone Mar 21, 2023
@jhoeller
Copy link
Contributor

Superseded by PR #30108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: documentation A documentation task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation for Vavr's Try method to trigger transaction rollbacks edyda99/spring-framework
4 participants
@sbrannen @odrotbohm @jhoeller @spring-projects-issues