Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.springframework.web.socket.server.standard.SpringConfiguratorTests has a configuration class that scans itself #32535

Closed
snicoll opened this issue Mar 26, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Mar 26, 2024

In our efforts to get rid of bean overriding in the core framework, I've found a weird setup arrangement in SpringConfiguratorTests that as a @Configuration class that scans its own package. This has the outcome of registering the configuration class twice.

Given that the package has other tests, we should make this test setup more robust by not relying on classpath scanning.

@snicoll snicoll added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Mar 26, 2024
@snicoll snicoll added this to the 6.2.0-M1 milestone Mar 26, 2024
@snicoll snicoll self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant