Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestOverrideMetadata and adapt tests to use a simple implementation #32982

Closed
snicoll opened this issue Jun 7, 2024 · 1 comment
Closed
Assignees
Labels
in: test Issues in the test module type: task A general task
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jun 7, 2024

The root package of bean override (org.springframework.test.context.bean.override) does not provide a simple implementation so some tests are relying on ExampleBeanOverrideAnnotation. This "test" implementation is doing a lot of things internally and I am not sure it should.

Its usage is now restricted to BeanOverrideBeanFactoryPostProcessorTests which could use something a bit more simpler certainly.

@snicoll snicoll added in: test Issues in the test module type: task A general task labels Jun 7, 2024
@snicoll snicoll added this to the 6.2.x milestone Jun 7, 2024
@snicoll
Copy link
Member Author

snicoll commented Jun 8, 2024

Case in point, TestOverrideMetadata is actually hiding a bug, see #32990. I found out when adapting this test to a vanilla implementation that doesn't do anything fancy.

@snicoll snicoll self-assigned this Jun 8, 2024
@snicoll snicoll modified the milestones: 6.2.x, 6.2.0-M4 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant