Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactorNettyClientRequest.convertException should include original exception if cause is null #33080

Closed
jhoeller opened this issue Jun 20, 2024 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@jhoeller
Copy link
Contributor

one update:

in
your fix

you throw in ReactorNettyClientRequest::convertException - after falling thru - the IOException this way:

return new IOException(ex.getMessage(), cause);

In case of eg. a io.netty.handler.timeout.ReadTimeoutException both are null - the message plus the cause.
So you loose the connex to ex and that it was a timeout that caused the exception.

Consumers like org.springframework.web.client.DefaultRestClient.DefaultRequestBodyUriSpec#createResourceAccessException
don't have this information at hand and throw a ResourceAccessException with "null" message.

Originally posted by @helmut-hackl-dynatrace in #32952 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant