Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize message conversion for HTTP message content in AssertJ support #33148

Closed
snicoll opened this issue Jul 4, 2024 · 0 comments
Closed
Assignees
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jul 4, 2024

Our AssertJ support has dedicated support for converting JSON to data types. Some recent work required to adapt things a bit, see #33131.

While working on this, I've come to realize that providing the raw converter isn't great as:

  1. Only one converter can be used and we miss cases where specific converters could handle specific data types
  2. Supporting other formats (such as XML) would require a signature change.

This issue is about trying to adapt things to address both of these issue. This should effectively supersede #33131 as we'd be handling more than one converter anyway.

@snicoll snicoll added in: test Issues in the test module type: enhancement A general enhancement labels Jul 4, 2024
@snicoll snicoll added this to the 6.2.0-M5 milestone Jul 4, 2024
@snicoll snicoll self-assigned this Jul 4, 2024
@snicoll snicoll closed this as completed in 4bdb772 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant