Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow avoiding lower-casing host/domain in UrlParser #33360

Closed
OlgaMaciaszek opened this issue Aug 9, 2024 · 2 comments
Closed

Allow avoiding lower-casing host/domain in UrlParser #33360

OlgaMaciaszek opened this issue Aug 9, 2024 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@OlgaMaciaszek
Copy link
Contributor

In some of the Spring Cloud scenarios, we expect the users to place serviceId instead of actual host/domain, and then we use it for load-balancing, getting instances from service registries, resolving contract stubs, etc., and various of these integrations are case-sensitive. Could a way be introduced to skip lower-casing (for example as a temporary solution till the next portfolio major is released)?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 9, 2024
@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Aug 9, 2024
@rstoyanchev rstoyanchev self-assigned this Aug 10, 2024
@rstoyanchev rstoyanchev added this to the 6.2.x milestone Aug 10, 2024
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 10, 2024
@rstoyanchev rstoyanchev modified the milestones: 6.2.x, 6.2.0-RC2 Sep 19, 2024
@rstoyanchev
Copy link
Contributor

This should work out again after #33639.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@rstoyanchev rstoyanchev removed this from the 6.2.0-RC2 milestone Oct 7, 2024
@rstoyanchev rstoyanchev added the status: superseded An issue that has been superseded by another label Oct 7, 2024
@OlgaMaciaszek
Copy link
Contributor Author

Thanks @rstoyanchev. Our tests now pass against FW snapshots.

This was referenced Oct 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rstoyanchev @jhoeller @OlgaMaciaszek @spring-projects-issues