Skip to content

Add default handling for disconnected client errors to Spring MVC #33763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Oct 21, 2024 · 1 comment
Closed

Add default handling for disconnected client errors to Spring MVC #33763

rstoyanchev opened this issue Oct 21, 2024 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.2.0-RC3

Comments

@rstoyanchev
Copy link
Contributor

Spring MVC has default handling for AsyncRequestNotUsableException after #33225 which is raised by our response wrapper when the response fails during an async request. However, the Servlet container may also notify via onError of the IOException, and if that gets through first, it remains unresolved, and that brings unnecessary logging.

WebFlux has default handling for disconnected client errors. We need to add similar in Spring MVC.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 21, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0 milestone Oct 21, 2024
@rstoyanchev rstoyanchev self-assigned this Oct 21, 2024
@rstoyanchev rstoyanchev mentioned this issue Oct 21, 2024
Closed
@rstoyanchev
Copy link
Contributor Author

Fixed in 9252e74 but commit references unrelated issue.

@rstoyanchev rstoyanchev mentioned this issue Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC3
Development

No branches or pull requests
1 participant
@rstoyanchev