Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure JdkAopProxyTests and CglibAopProxyTests are actually run in the Gradle build #33797

Closed
sbrannen opened this issue Oct 25, 2024 · 0 comments
Closed

Ensure JdkAopProxyTests and CglibAopProxyTests are actually run in the Gradle build #33797

sbrannen opened this issue Oct 25, 2024 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Milestone
6.2.0

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 25, 2024 •
edited
Loading

Overview

The abstract ProxyExceptionHandlingTests class introduced in #32469 has a rather odd structure of inheritance and @Nested test classes which results in the static nested JdkAopProxyTests and CglibAopProxyTests classes not being run (or at least reported correctly) in our Gradle build.

We should therefore rework those classes to ensure the tests are actually run.

Related issues
@sbrannen sbrannen added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) labels Oct 25, 2024
@sbrannen sbrannen added this to the 6.2.0 milestone Oct 25, 2024
@sbrannen sbrannen self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
1 participant
@sbrannen