VelocityToolboxViewResolver and VelocityLayoutViewResolver [SPR-941]

[spring-projects-issues]

Shinobu Kawai opened SPR-941 and commented

Currently, you can't inject a configured VelocityLayoutView into the VelocityViewResolver. (Or can you?)

I created a VelocityToolboxViewResolver and a VelocityLayoutViewResolver to solve my problem. The whole structure kind of smells, but it looks clean for now. :)

For the VelocityToolboxViewResolver, you can add the "toolboxConfigLocation" property to specify your toolbox.xml as you would in VelocityToolboxView. This causes some backward incompatability, as I moved the property down from VelocityViewResolver, but all you have to do is change the view resolver class name. (And it was added in 1.2rc2 anyways.)

For the VelocityLayoutViewResolver, in addition to the toolbox stuff, you can add the "layoutUrl", "layoutKey" and "screenContentKey" properties in respect with the same properties of VelocityLayoutView.

---

Attachments:

• SPR-941.VelocityViewResolver.patch (2.17 kB)
• SPR-941.VelocityViewResolver.patch (2.08 kB)
• VelocityLayoutViewResolver.java (3.95 kB)
• VelocityLayoutViewResolver.java (4.00 kB)
• VelocityToolboxViewResolver.java (2.97 kB)
• VelocityToolboxViewResolver.java (3.02 kB)

2 votes, 3 watchers

[spring-projects-issues]

Shinobu Kawai commented

move toolbox support to VelocityToolboxViewResolver

[spring-projects-issues]

Shinobu Kawai commented

view resolver w/ toolbox support

[spring-projects-issues]

Shinobu Kawai commented

view resolver w/ layout support

[spring-projects-issues]

Shinobu Kawai commented

replaces attach #1 for Spring 1.2 (CVS HEAD)

[spring-projects-issues]

Shinobu Kawai commented

replaces VelocityToolboxViewResolver.java uploaded on 12/May/05 for Spring 1.2 (CVS HEAD)

[spring-projects-issues]

Shinobu Kawai commented

replaces VelocityLayoutViewResolver.java uploaded on 12/May/05 for Spring 1.2 (CVS HEAD)

[spring-projects-issues]

Juergen Hoeller commented

A VelocityLayoutViewResolver sounds plausible to me. But why have you factored out the "toolboxConfigLocation" support into a VelocityToolboxViewResolver class? Couldn't it simply stay in VelocityViewResolver?

Juergen

[spring-projects-issues]

Shinobu Kawai commented

VelocityViewResolver#setToolboxConfigLocation looked kind of messy on first impression. The behaviour wasn't intuitive, I usually don't expect a setter to change the state of the instance. Maybe logging a warning that the view class was overwritten would have sufficed.

[spring-projects-issues]

Juergen Hoeller commented

I've added a fresh cut of a VelocityLayoutViewResolver to both Spring 2.0 M3 and 1.2.7. I've kept the toolbox support in VelocityViewResolver itself, although with a refined initialization procedure.

Juergen