Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring MVC Interceptor Documentation [SPR-5158] #9831

Closed
spring-projects-issues opened this issue Sep 16, 2008 · 1 comment
Closed

Spring MVC Interceptor Documentation [SPR-5158] #9831

spring-projects-issues opened this issue Sep 16, 2008 · 1 comment
Labels
type: documentation A documentation task type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Stephen M. Wick opened SPR-5158 and commented

When I read section 13.4.3 "Intercepting requests - the HandlerInterceptor interface", I am left wondering, "Do the interceptors specified in the handler mapping bean get invoked for every request handled by the DisplatcherServlet, or do they just get invoked when a request matches one of the URL patterns specified in the mappings property of the handler mapping bean?"

I think it would be a good idea to answer this question in the Spring reference document under section 13.4.3.

Thanks! And, Great work! The Spring Framework project has been so helpful!

Stephen


Affects: 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9

Referenced from: commits 95ad3c9

@spring-projects-issues
Copy link
Collaborator Author

Luke Taylor commented

This seems more a lack of understanding of the handler mapping itself. The doc seems reasonably clear that the interceptor is part of the handler mapping, and hence is only applied to requests which are handled by that mapping. However, I've expanded the text a bit to spell this out, particularly w.r.t. the sample code.

@spring-projects-issues spring-projects-issues added type: documentation A documentation task type: enhancement A general enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 RC3 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant