PropertyValue does not copy the converted semantics of a given pv [SPR-5293]

[spring-projects-issues]

Costin Leau opened SPR-5293 and commented

Constructor PropertyValue(PropertyValue) does not copy all the properties of the given pv. In my case, the given pv is converted already which means the converted flag is set to true. However, the constructor does not copies this field (though it does copy conversionNecessary which is package protected) which means the property gets converted again on the next run. Additionally, the converted value is ignored as well.
Not sure what's the relationship between resolvedTokens and convertedValue but the two should be synchronized somehow.

(I've attached a patch with a trivial fix)

---

Affects: 2.5.6

Attachments:

• patch.txt (852 bytes)

Referenced from: commits 46cbaa9

[spring-projects-issues]

Juergen Hoeller commented

Hey Costin,

After a bit of research, I couldn't come up with a good reason for not copying the converted value there either... for the constructor that fully copies a given PropertyValue (in contrast to the constructor that overrides an existing PropertyValue with a new value object). So I've changed it for 3.0 M2.

Juergen