StackOverflowError when using MessageListenerAdapter without delegate [SPR-5309]

[spring-projects-issues]

Alexander Grupe opened SPR-5309 and commented

When using the constructor without specifying a delegate...

public MessageListenerAdapter() {
	initDefaultStrategies();
	this.delegate = this;
}

...the next call to getSubscriptionName leads to an endless loop:

public String getSubscriptionName() {
	if (this.delegate instanceof SubscriptionNameProvider) {
		return ((SubscriptionNameProvider) this.delegate).getSubscriptionName();
	}
	else {
		return this.delegate.getClass().getName();
	}
}

This is for example called in AbstractMessageListenerContainer.setMessageListener. Before the introduction of SubscriptionNameProvider in 2.5.6, by default the message listener's class name was used.

---

Affects: 2.5.6

Referenced from: commits 2674b13

3 votes, 5 watchers

[spring-projects-issues]

Alexander Grupe commented

Addendum: The reason for the endlees loop is that MessageListenerAdapter implements SubscriptionNameProvider itself.

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out! Fixed in 3.0 M2 now.

Juergen

[spring-projects-issues]

Lars Oppermann commented

It would be nice to have a fix for this in the 2.5 branch