Skip to content

Commit d0f07eb

Browse files
committed
Remove unnecessary SuppressWarnings
Remove unnecessary if statements following review
1 parent 21dce27 commit d0f07eb

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

spring-integration-core/src/main/java/org/springframework/integration/support/BaseMessageBuilder.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.springframework.messaging.support.ErrorMessage;
3333
import org.springframework.messaging.support.GenericMessage;
3434
import org.springframework.util.Assert;
35-
import org.springframework.util.ObjectUtils;
3635

3736
/**
3837
* The {@link AbstractIntegrationMessageBuilder} extension for the default logic to build message.
@@ -64,12 +63,10 @@ public abstract class BaseMessageBuilder<T, B extends BaseMessageBuilder<T, B>>
6463

6564
private final IntegrationMessageHeaderAccessor headerAccessor;
6665

67-
@Nullable
68-
private final Message<T> originalMessage;
66+
private final @Nullable Message<T> originalMessage;
6967

7068
private volatile boolean modified;
7169

72-
@SuppressWarnings("NullAway.Init")
7370
private String @Nullable [] readOnlyHeaders;
7471

7572
protected BaseMessageBuilder(T payload, @Nullable Message<T> originalMessage) {
@@ -287,7 +284,7 @@ public B setPriority(Integer priority) {
287284
* @return the current {@link BaseMessageBuilder}
288285
* @see IntegrationMessageHeaderAccessor#isReadOnly(String)
289286
*/
290-
public B readOnlyHeaders(String... readOnlyHeaders) {
287+
public B readOnlyHeaders(String @Nullable ... readOnlyHeaders) {
291288
this.readOnlyHeaders = readOnlyHeaders != null ? Arrays.copyOf(readOnlyHeaders, readOnlyHeaders.length) : null;
292289
if (readOnlyHeaders != null) {
293290
this.headerAccessor.setReadOnlyHeaders(readOnlyHeaders);
@@ -319,9 +316,9 @@ public Message<T> build() {
319316
}
320317

321318
private boolean containsReadOnly(MessageHeaders headers) {
322-
if (!ObjectUtils.isEmpty(this.readOnlyHeaders)) {
319+
if (this.readOnlyHeaders != null) {
323320
for (String readOnly : this.readOnlyHeaders) {
324-
if (readOnly != null && headers.containsKey(readOnly)) {
321+
if (headers.containsKey(readOnly)) {
325322
return true;
326323
}
327324
}

spring-integration-core/src/main/java/org/springframework/integration/support/DefaultMessageBuilderFactory.java

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
*/
3333
public class DefaultMessageBuilderFactory implements MessageBuilderFactory {
3434

35-
@SuppressWarnings("NullAway.Init")
3635
private String @Nullable [] readOnlyHeaders;
3736

3837
/**
@@ -66,24 +65,14 @@ public void addReadOnlyHeaders(String... readOnlyHeaders) {
6665

6766
@Override
6867
public <T> MessageBuilder<T> fromMessage(Message<T> message) {
69-
if (this.readOnlyHeaders != null) {
70-
return MessageBuilder.fromMessage(message)
71-
.readOnlyHeaders(this.readOnlyHeaders);
72-
}
73-
else {
74-
return MessageBuilder.fromMessage(message);
75-
}
68+
return MessageBuilder.fromMessage(message)
69+
.readOnlyHeaders(this.readOnlyHeaders);
7670
}
7771

7872
@Override
7973
public <T> MessageBuilder<T> withPayload(T payload) {
80-
if (this.readOnlyHeaders != null) {
81-
return MessageBuilder.withPayload(payload)
82-
.readOnlyHeaders(this.readOnlyHeaders);
83-
}
84-
else {
85-
return MessageBuilder.withPayload(payload);
86-
}
74+
return MessageBuilder.withPayload(payload)
75+
.readOnlyHeaders(this.readOnlyHeaders);
8776
}
8877

8978
}

0 commit comments

Comments
 (0)