Skip to content

Commit d96b8e0

Browse files
committed
Fix Tests for Shared DefaultConversionService
JIRA: https://jira.spring.io/browse/SPR-14948 The `StandardTypeConverter` no longer has a `defaultConversionService` field, it uses a static instance from `DefaultConversionService`.`
1 parent 5df0ef6 commit d96b8e0

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

spring-integration-core/src/test/java/org/springframework/integration/expression/ExpressionUtilsTests.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.springframework.beans.factory.support.RootBeanDefinition;
2727
import org.springframework.context.support.ConversionServiceFactoryBean;
2828
import org.springframework.context.support.GenericApplicationContext;
29+
import org.springframework.core.convert.support.DefaultConversionService;
2930
import org.springframework.expression.TypeConverter;
3031
import org.springframework.expression.spel.support.StandardEvaluationContext;
3132
import org.springframework.integration.config.IntegrationEvaluationContextFactoryBean;
@@ -67,7 +68,8 @@ public void testEvaluationContextDefaultTypeConverter() {
6768
assertNotNull(evalContext.getBeanResolver());
6869
TypeConverter typeConverter = evalContext.getTypeConverter();
6970
assertNotNull(typeConverter);
70-
assertSame(TestUtils.getPropertyValue(typeConverter, "defaultConversionService"), TestUtils.getPropertyValue(typeConverter, "conversionService"));
71+
assertSame(DefaultConversionService.getSharedInstance(),
72+
TestUtils.getPropertyValue(typeConverter, "conversionService"));
7173
}
7274

7375
@Test
@@ -80,7 +82,7 @@ public void testEvaluationContextNoFactoryBean() {
8082
assertNotNull(evalContext.getBeanResolver());
8183
TypeConverter typeConverter = evalContext.getTypeConverter();
8284
assertNotNull(typeConverter);
83-
assertNotSame(TestUtils.getPropertyValue(typeConverter, "defaultConversionService"),
85+
assertNotSame(DefaultConversionService.getSharedInstance(),
8486
TestUtils.getPropertyValue(typeConverter, "conversionService"));
8587
assertSame(context.getBean(IntegrationUtils.INTEGRATION_CONVERSION_SERVICE_BEAN_NAME),
8688
TestUtils.getPropertyValue(typeConverter, "conversionService"));
@@ -92,7 +94,7 @@ public void testEvaluationContextNoBeanFactory() {
9294
assertNull(evalContext.getBeanResolver());
9395
TypeConverter typeConverter = evalContext.getTypeConverter();
9496
assertNotNull(typeConverter);
95-
assertSame(TestUtils.getPropertyValue(typeConverter, "defaultConversionService"),
97+
assertSame(DefaultConversionService.getSharedInstance(),
9698
TestUtils.getPropertyValue(typeConverter, "conversionService"));
9799
}
98100
}

0 commit comments

Comments
 (0)