Skip to content

Commit 7641bb5

Browse files
artembilangaryrussell
authored andcommitted
GH-1109: Remove deprecated KafkaEmbedded
Fixes #1109 Since we can't guarantee that JUnit 4 is going to be on classpath for the `KafkaTestUtils` it would be better to remove already deprecated methods in that class for the `KafkaEmbedded`. At the same time since the `KafkaEmbedded` is deprecated already and there is a good workaround with a new code, remove it altogether as well
1 parent c906d0e commit 7641bb5

File tree

3 files changed

+0
-329
lines changed

3 files changed

+0
-329
lines changed

spring-kafka-test/src/main/java/org/springframework/kafka/test/rule/KafkaEmbedded.java

Lines changed: 0 additions & 250 deletions
This file was deleted.

spring-kafka-test/src/main/java/org/springframework/kafka/test/rule/KafkaRule.java

Lines changed: 0 additions & 52 deletions
This file was deleted.

spring-kafka-test/src/main/java/org/springframework/kafka/test/utils/KafkaTestUtils.java

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -57,33 +57,6 @@ private KafkaTestUtils() {
5757
// private ctor
5858
}
5959

60-
/**
61-
* Set up test properties for an {@code <Integer, String>} consumer.
62-
* @param group the group id.
63-
* @param autoCommit the auto commit.
64-
* @param embeddedKafka a {@link org.springframework.kafka.test.rule.KafkaEmbedded} instance.
65-
* @return the properties.
66-
* @deprecated since 2.2 in favor of {@link #consumerProps(String, String, EmbeddedKafkaBroker)}
67-
*/
68-
@SuppressWarnings("deprecation")
69-
@Deprecated
70-
public static Map<String, Object> consumerProps(String group, String autoCommit,
71-
org.springframework.kafka.test.rule.KafkaEmbedded embeddedKafka) {
72-
return consumerProps(embeddedKafka.getBrokersAsString(), group, autoCommit);
73-
}
74-
75-
/**
76-
* Set up test properties for an {@code <Integer, String>} producer.
77-
* @param embeddedKafka a {@link org.springframework.kafka.test.rule.KafkaEmbedded} instance.
78-
* @return the properties.
79-
* @deprecated since 2.2 in favor of {@link #producerProps(EmbeddedKafkaBroker)}
80-
*/
81-
@SuppressWarnings("deprecation")
82-
@Deprecated
83-
public static Map<String, Object> producerProps(org.springframework.kafka.test.rule.KafkaEmbedded embeddedKafka) {
84-
return senderProps(embeddedKafka.getBrokersAsString());
85-
}
86-
8760
/**
8861
* Set up test properties for an {@code <Integer, String>} consumer.
8962
* @param group the group id.

0 commit comments

Comments
 (0)