Skip to content

Commit ebe4c9b

Browse files
committed
Fix commitSync() calls race condition
Looks like the `KafkaConsumer.commitSync()` may be called more then 3 (and then 4) time during testing
1 parent a5bfe1b commit ebe4c9b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

spring-kafka/src/test/java/org/springframework/kafka/listener/KafkaMessageListenerContainerTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import static org.mockito.ArgumentMatchers.isNull;
2424
import static org.mockito.BDDMockito.given;
2525
import static org.mockito.BDDMockito.willAnswer;
26+
import static org.mockito.Mockito.atLeast;
2627
import static org.mockito.Mockito.inOrder;
2728
import static org.mockito.Mockito.mock;
2829
import static org.mockito.Mockito.spy;
@@ -1933,7 +1934,7 @@ else if (e instanceof ConsumerStoppedEvent) {
19331934
});
19341935
container.start();
19351936
assertThat(commitLatch.await(10, TimeUnit.SECONDS)).isTrue();
1936-
verify(consumer, times(3)).commitSync(anyMap());
1937+
verify(consumer, atLeast(3)).commitSync(anyMap());
19371938
assertThat(container.isContainerPaused()).isFalse();
19381939
container.pause();
19391940
assertThat(container.isPaused()).isTrue();
@@ -1945,7 +1946,7 @@ else if (e instanceof ConsumerStoppedEvent) {
19451946
assertThat(resumeLatch.await(10, TimeUnit.SECONDS)).isTrue();
19461947
container.stop();
19471948
assertThat(stopLatch.await(10, TimeUnit.SECONDS)).isTrue();
1948-
verify(consumer, times(4)).commitSync(anyMap());
1949+
verify(consumer, atLeast(4)).commitSync(anyMap());
19491950
}
19501951

19511952
@SuppressWarnings({ "unchecked", "rawtypes" })

0 commit comments

Comments
 (0)