Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading semantics in the reader poller #347

Open
sobychacko opened this issue Feb 15, 2023 · 0 comments
Open

Reading semantics in the reader poller #347

sobychacko opened this issue Feb 15, 2023 · 0 comments
Labels
type: improvement An improvement of implementation of existing feature
Milestone
Backlog

Comments

@sobychacko
Copy link
Collaborator

sobychacko commented Feb 15, 2023 •
edited by onobc
Loading

Should we consider using read next w/ timeout? What about when it reaches end of topic? Does the listener just sit and wait for data on the topic to come in?

This is fine for the 1st pass but I think we may want to look into a combination of readNext(int, TimeUnit) + hasMessageAvailable (or something) to avoid the blocking. It does not feel efficient. That being said, this can be a "duly noted" comment and we can noodle on it a bit and handle in later PR. Just capturing my thoughts.

Originally posted by @onobc in #342 (comment)
@sobychacko sobychacko mentioned this issue Feb 15, 2023
Merged
@onobc onobc added type: feature A new feature or enhacement type: improvement An improvement of implementation of existing feature and removed type: feature A new feature or enhacement labels Nov 23, 2023
@onobc onobc added this to the Backlog milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: improvement An improvement of implementation of existing feature
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sobychacko @onobc