Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PulsarServiceConnection support when Spring Boot 3.2.0 is supported #384

Closed
eddumelendez opened this issue Mar 25, 2023 · 4 comments
Closed

Comments

@eddumelendez
Copy link
Contributor

In Spring Boot 3.1.0-M2, Service Connections was introduced.

It would be great to do the same for the project and introduce PulsarServiceConnection and set automatically the following properties spring.pulsar.client.serviceUrl and spring.pulsar.administration.service-url.

At the current state, probably won't be possible unless there is a test module but could be too much. I guess, the proper time would be when merging the autoconfiguration in spring boot support which I hope could be for 3.1.0 release.

@onobc
Copy link
Collaborator

onobc commented Mar 25, 2023

Thanks for sharing this @eddumelendez ! This is news to me and is very exciting. I look forward to not having to do the @DynamicPropertySource every time I use @Container in a @SpringBootTest just to pass in the server/port info.

Not sure if it will make it in time for the 3.1.0 - but I did just submit the PR for the merge into SB here. There will already be too many moving parts to also include the service connection in the initial PR. It would be nice to follow directly after though w/ this support.

@eddumelendez
Copy link
Contributor Author

Thanks for point me to the PR @onobc ! I didn't see that coming 😅

@onobc
Copy link
Collaborator

onobc commented Jun 2, 2023

Putting this info here to avoid duplication of work in the case where someone sees this issue and decides to implement it as well - I have implemented this (but queued up on the initial SB PR) spring-projects/spring-boot#34763 (comment)

@onobc onobc changed the title Add PulsarServiceConnection support when Spring Boot 3.1.0-M2 is supported Add PulsarServiceConnection support when Spring Boot 3.2.0 is supported Sep 6, 2023
@onobc
Copy link
Collaborator

onobc commented Sep 6, 2023

Closed via spring-projects/spring-boot@d9af7ce

@onobc onobc closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants