Skip to content

Commit

Permalink
Add SpringSessionBackedReactiveSessionRegistry
Browse files Browse the repository at this point in the history
Closes gh-2824
  • Loading branch information
marcusdacoregio committed Feb 28, 2024
1 parent 203a100 commit 223a90f
Show file tree
Hide file tree
Showing 19 changed files with 997 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ org-slf4j-jcl-over-slf4j = { module = "org.slf4j:jcl-over-slf4j", version.ref =
org-slf4j-log4j-over-slf4j = { module = "org.slf4j:log4j-over-slf4j", version.ref = "org-slf4j" }
org-slf4j-slf4j-api = { module = "org.slf4j:slf4j-api", version.ref = "org-slf4j" }
org-springframework-data-spring-data-bom = "org.springframework.data:spring-data-bom:2024.0.0-M1"
org-springframework-security-spring-security-bom = "org.springframework.security:spring-security-bom:6.3.0-M2"
org-springframework-security-spring-security-bom = "org.springframework.security:spring-security-bom:6.3.0-SNAPSHOT"
org-springframework-spring-framework-bom = "org.springframework:spring-framework-bom:6.1.4"
org-springframework-boot-spring-boot-dependencies = { module = "org.springframework.boot:spring-boot-dependencies", version.ref = "org-springframework-boot" }
org-springframework-boot-spring-boot-gradle-plugin = { module = "org.springframework.boot:spring-boot-gradle-plugin", version.ref = "org-springframework-boot" }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
/*
* Copyright 2014-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.session.security;

import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;

import org.springframework.security.authentication.AbstractAuthenticationToken;
import org.springframework.security.core.Authentication;
import org.springframework.security.core.authority.AuthorityUtils;
import org.springframework.security.core.context.SecurityContext;
import org.springframework.security.core.session.ReactiveSessionInformation;
import org.springframework.security.core.session.ReactiveSessionRegistry;
import org.springframework.session.ReactiveFindByIndexNameSessionRepository;
import org.springframework.session.ReactiveSessionRepository;
import org.springframework.session.Session;
import org.springframework.util.Assert;

/**
* A {@link ReactiveSessionRegistry} that retrieves session information from Spring
* Session, rather than maintaining it itself. This allows concurrent session management
* with Spring Security in a clustered environment.
* <p>
* Relies on being able to derive the same String-based representation of the principal
* given to {@link #getAllSessions(Object)} as used by Spring Session in order to look up
* the user's sessions.
* <p>
*
* @param <S> the {@link Session} type.
* @author Marcus da Coregio
* @since 3.3
*/
public final class SpringSessionBackedReactiveSessionRegistry<S extends Session> implements ReactiveSessionRegistry {

private static final String SPRING_SECURITY_CONTEXT = "SPRING_SECURITY_CONTEXT";

private final ReactiveSessionRepository<S> sessionRepository;

private final ReactiveFindByIndexNameSessionRepository<S> indexedSessionRepository;

public SpringSessionBackedReactiveSessionRegistry(ReactiveSessionRepository<S> sessionRepository,
ReactiveFindByIndexNameSessionRepository<S> indexedSessionRepository) {
Assert.notNull(sessionRepository, "sessionRepository cannot be null");
Assert.notNull(indexedSessionRepository, "indexedSessionRepository cannot be null");
this.sessionRepository = sessionRepository;
this.indexedSessionRepository = indexedSessionRepository;
}

@Override
public Flux<ReactiveSessionInformation> getAllSessions(Object principal) {
Authentication authenticationToken = getAuthenticationToken(principal);
return this.indexedSessionRepository.findByPrincipalName(authenticationToken.getName())
.flatMapMany((sessionMap) -> Flux.fromIterable(sessionMap.entrySet()))
.map((entry) -> new SpringSessionBackedReactiveSessionInformation(entry.getValue()));
}

@Override
public Mono<Void> saveSessionInformation(ReactiveSessionInformation information) {
return Mono.empty();
}

@Override
public Mono<ReactiveSessionInformation> getSessionInformation(String sessionId) {
return this.sessionRepository.findById(sessionId).map(SpringSessionBackedReactiveSessionInformation::new);
}

@Override
public Mono<ReactiveSessionInformation> removeSessionInformation(String sessionId) {
return Mono.empty();
}

@Override
public Mono<ReactiveSessionInformation> updateLastAccessTime(String sessionId) {
return Mono.empty();
}

private static Authentication getAuthenticationToken(Object principal) {
return new AbstractAuthenticationToken(AuthorityUtils.NO_AUTHORITIES) {

@Override
public Object getCredentials() {
return null;
}

@Override
public Object getPrincipal() {
return principal;
}

};
}

class SpringSessionBackedReactiveSessionInformation extends ReactiveSessionInformation {

SpringSessionBackedReactiveSessionInformation(S session) {
super(resolvePrincipalName(session), session.getId(), session.getLastAccessedTime());
}

private static String resolvePrincipalName(Session session) {
String principalName = session
.getAttribute(ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME);
if (principalName != null) {
return principalName;
}
SecurityContext securityContext = session.getAttribute(SPRING_SECURITY_CONTEXT);
if (securityContext != null && securityContext.getAuthentication() != null) {
return securityContext.getAuthentication().getName();
}
return "";
}

@Override
public Mono<Void> invalidate() {
return super.invalidate()
.then(Mono.defer(() -> SpringSessionBackedReactiveSessionRegistry.this.sessionRepository
.deleteById(getSessionId())));
}

}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
/*
* Copyright 2014-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.session.security;

import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;

import org.springframework.security.authentication.TestingAuthenticationToken;
import org.springframework.security.core.context.SecurityContextImpl;
import org.springframework.security.core.session.ReactiveSessionInformation;
import org.springframework.session.MapSession;
import org.springframework.session.ReactiveFindByIndexNameSessionRepository;
import org.springframework.session.ReactiveMapSessionRepository;

import static org.assertj.core.api.Assertions.assertThat;

class SpringSessionBackedReactiveSessionRegistryTests {

static MapSession johnSession1 = new MapSession();
static MapSession johnSession2 = new MapSession();
static MapSession johnSession3 = new MapSession();

SpringSessionBackedReactiveSessionRegistry<MapSession> sessionRegistry;

ReactiveFindByIndexNameSessionRepository<MapSession> indexedSessionRepository = new StubIndexedSessionRepository();

ReactiveMapSessionRepository sessionRepository = new ReactiveMapSessionRepository(new ConcurrentHashMap<>());

static {
johnSession1.setAttribute(ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME, "johndoe");
johnSession2.setAttribute(ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME, "johndoe");
johnSession3.setAttribute(ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME, "johndoe");
}

@BeforeEach
void setup() {
this.sessionRegistry = new SpringSessionBackedReactiveSessionRegistry<>(this.sessionRepository,
this.indexedSessionRepository);
this.sessionRepository.save(johnSession1).block();
this.sessionRepository.save(johnSession2).block();
this.sessionRepository.save(johnSession3).block();
}

@Test
void saveSessionInformationThenDoNothing() {
StepVerifier.create(this.sessionRegistry.saveSessionInformation(null)).expectComplete().verify();
}

@Test
void removeSessionInformationThenDoNothing() {
StepVerifier.create(this.sessionRegistry.removeSessionInformation(null)).expectComplete().verify();
}

@Test
void updateLastAccessTimeThenDoNothing() {
StepVerifier.create(this.sessionRegistry.updateLastAccessTime(null)).expectComplete().verify();
}

@Test
void getSessionInformationWhenPrincipalIndexNamePresentThenPrincipalResolved() {
MapSession session = this.sessionRepository.createSession().block();
session.setAttribute(ReactiveFindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME, "johndoe");
this.sessionRepository.save(session).block();
StepVerifier.create(this.sessionRegistry.getSessionInformation(session.getId()))
.assertNext((sessionInformation) -> {
assertThat(sessionInformation.getSessionId()).isEqualTo(session.getId());
assertThat(sessionInformation.getLastAccessTime()).isEqualTo(session.getLastAccessedTime());
assertThat(sessionInformation.getPrincipal()).isEqualTo("johndoe");
})
.verifyComplete();
}

@Test
void getSessionInformationWhenSecurityContextAttributePresentThenPrincipalResolved() {
MapSession session = this.sessionRepository.createSession().block();
TestingAuthenticationToken authentication = new TestingAuthenticationToken("johndoe", "n/a");
SecurityContextImpl securityContext = new SecurityContextImpl();
securityContext.setAuthentication(authentication);
session.setAttribute("SPRING_SECURITY_CONTEXT", securityContext);
this.sessionRepository.save(session).block();
StepVerifier.create(this.sessionRegistry.getSessionInformation(session.getId()))
.assertNext((sessionInformation) -> {
assertThat(sessionInformation.getSessionId()).isEqualTo(session.getId());
assertThat(sessionInformation.getLastAccessTime()).isEqualTo(session.getLastAccessedTime());
assertThat(sessionInformation.getPrincipal()).isEqualTo("johndoe");
})
.verifyComplete();
}

@Test
void getSessionInformationWhenNoResolvablePrincipalThenPrincipalBlank() {
MapSession session = this.sessionRepository.createSession().block();
this.sessionRepository.save(session).block();
StepVerifier.create(this.sessionRegistry.getSessionInformation(session.getId()))
.assertNext((sessionInformation) -> {
assertThat(sessionInformation.getSessionId()).isEqualTo(session.getId());
assertThat(sessionInformation.getLastAccessTime()).isEqualTo(session.getLastAccessedTime());
assertThat(sessionInformation.getPrincipal()).isEqualTo("");
})
.verifyComplete();
}

@Test
void getSessionInformationWhenInvalidateThenRemovedFromSessionRepository() {
MapSession session = this.sessionRepository.createSession().block();
this.sessionRepository.save(session).block();
Mono<Void> publisher = this.sessionRegistry.getSessionInformation(session.getId())
.flatMap(ReactiveSessionInformation::invalidate);
StepVerifier.create(publisher).verifyComplete();
StepVerifier.create(this.sessionRepository.findById(session.getId())).expectComplete().verify();
}

@Test
void getAllSessionsWhenSessionsExistsThenReturned() {
Flux<ReactiveSessionInformation> sessions = this.sessionRegistry.getAllSessions("johndoe");
StepVerifier.create(sessions)
.assertNext((sessionInformation) -> assertThat(sessionInformation.getPrincipal()).isEqualTo("johndoe"))
.assertNext((sessionInformation) -> assertThat(sessionInformation.getPrincipal()).isEqualTo("johndoe"))
.assertNext((sessionInformation) -> assertThat(sessionInformation.getPrincipal()).isEqualTo("johndoe"))
.verifyComplete();
}

@Test
void getAllSessionsWhenInvalidateThenSessionsRemovedFromRepository() {
this.sessionRegistry.getAllSessions("johndoe").flatMap(ReactiveSessionInformation::invalidate).blockLast();
StepVerifier.create(this.sessionRepository.findById(johnSession1.getId())).expectComplete().verify();
StepVerifier.create(this.sessionRepository.findById(johnSession2.getId())).expectComplete().verify();
StepVerifier.create(this.sessionRepository.findById(johnSession3.getId())).expectComplete().verify();
}

static class StubIndexedSessionRepository implements ReactiveFindByIndexNameSessionRepository<MapSession> {

Map<String, MapSession> johnSessions = Map.of(johnSession1.getId(), johnSession1, johnSession2.getId(),
johnSession2, johnSession3.getId(), johnSession3);

@Override
public Mono<Map<String, MapSession>> findByIndexNameAndIndexValue(String indexName, String indexValue) {
if ("johndoe".equals(indexValue)) {
return Mono.just(this.johnSessions);
}
return Mono.empty();
}

}

}
27 changes: 27 additions & 0 deletions spring-session-docs/modules/ROOT/pages/configuration/common.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ It contains configuration examples for the following use cases:

- I need to <<changing-how-session-ids-are-generated,change the way that Session IDs are generated>>
- I need to <<customizing-session-cookie,customize the session cookie properties>>
- I want to <<spring-session-backed-reactive-session-registry,provide a Spring Session implementation of the `ReactiveSessionRepository`>> for {spring-security-ref-docs}/reactive/authentication/concurrent-sessions-control.html[Concurrent Sessions Control]

[[changing-how-session-ids-are-generated]]
== Changing How Session IDs Are Generated
Expand Down Expand Up @@ -137,3 +138,29 @@ include::{samples-dir}spring-session-sample-boot-webflux-custom-cookie/src/main/
<2> We customize the path of the cookie to be `/` (rather than the default of the context root).
<3> We customize the `SameSite` cookie directive to be `Strict`.
====

[[spring-session-backed-reactive-session-registry]]
== Providing a Spring Session implementation of `ReactiveSessionRegistry`

Spring Session provides integration with Spring Security to support its reactive concurrent session control.
This allows limiting the number of active sessions that a single user can have concurrently, but, unlike the default Spring Security support, this also works in a clustered environment.
This is done by providing the `SpringSessionBackedReactiveSessionRegistry` implementation of Spring Security’s `ReactiveSessionRegistry` interface.

.Defining SpringSessionBackedReactiveSessionRegistry as a bean
[tabs]
======
Java::
+
[source,java,role="primary"]
----
@Bean
public <S extends Session> SpringSessionBackedReactiveSessionRegistry<S> sessionRegistry(
ReactiveSessionRepository<S> sessionRepository,
ReactiveFindByIndexNameSessionRepository<S> indexedSessionRepository) {
return new SpringSessionBackedReactiveSessionRegistry<>(sessionRepository, indexedSessionRepository);
}
----
======

Please, refer to {spring-security-ref-docs}/reactive/authentication/concurrent-sessions-control.html[Spring Security Concurrent Sessions Control documentation] for more ways of using the `ReactiveSessionRegistry`.
You can also check a sample application https://github.com/spring-projects/spring-session/tree/main/spring-session-samples/spring-session-sample-boot-reactive-max-sessions[here].
6 changes: 6 additions & 0 deletions spring-session-docs/spring-session-docs.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,19 @@ def generateAttributes() {
springBootVersion = springBootVersion.contains("-")
? springBootVersion.substring(0, springBootVersion.indexOf("-"))
: springBootVersion
def springSecurityVersion = libs.org.springframework.security.spring.security.bom.get().version
springSecurityVersion = springSecurityVersion.contains("-")
? springSecurityVersion.substring(0, springSecurityVersion.indexOf("-"))
: springSecurityVersion
def ghTag = snapshotBuild ? 'main' : project.version
def docsUrl = 'https://docs.spring.io'
def springBootRefDocs = "${docsUrl}/spring-boot/docs/${springBootVersion}/reference/html"
def springSecurityRefDocs = "${docsUrl}/spring-security/reference/${springSecurityVersion}"
return ['gh-tag':ghTag,
'spring-boot-version': springBootVersion,
'spring-boot-ref-docs': springBootRefDocs.toString(),
'spring-session-version': project.version,
'spring-security-ref-docs': springSecurityRefDocs.toString(),
'docs-url': docsUrl]
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
apply plugin: 'io.spring.convention.spring-sample-boot'

ext['spring-security.version'] = '6.3.0-SNAPSHOT'

dependencies {
management platform(project(":spring-session-dependencies"))
implementation project(':spring-session-data-redis')
implementation 'org.springframework.boot:spring-boot-starter-data-redis-reactive'
implementation 'org.springframework.boot:spring-boot-starter-security'
implementation 'org.springframework.boot:spring-boot-starter-webflux'
implementation 'org.springframework.boot:spring-boot-starter-thymeleaf'
testImplementation 'org.springframework.boot:spring-boot-starter-test'
testImplementation 'io.projectreactor:reactor-test'
testImplementation 'org.springframework.security:spring-security-test'
testImplementation 'org.springframework.boot:spring-boot-testcontainers'
testImplementation 'org.testcontainers:junit-jupiter'
testImplementation 'org.seleniumhq.selenium:selenium-java'
testImplementation 'org.seleniumhq.selenium:htmlunit-driver'
}

tasks.named('test') {
useJUnitPlatform()
}
Loading

0 comments on commit 223a90f

Please sign in to comment.