PT 159667257 - Re-introduce hack to bypass LSP4E completion sorting

Author: nsingh@pivotal.io

headless-services/commons/commons-language-server/src/main/java/org/springframework/ide/vscode/commons/languageserver/completion/VscodeCompletionEngineAdapter.java

@@ -31,6 +31,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.ide.vscode.commons.languageserver.completion.DocumentEdits.TextReplace;
+import org.springframework.ide.vscode.commons.languageserver.util.LspClient;
+import org.springframework.ide.vscode.commons.languageserver.util.LspClient.Client;
 import org.springframework.ide.vscode.commons.languageserver.util.SimpleLanguageServer;
 import org.springframework.ide.vscode.commons.languageserver.util.SimpleTextDocumentService;
 import org.springframework.ide.vscode.commons.languageserver.util.SortKeys;
@@ -164,6 +166,12 @@ private Mono<CompletionList> getCompletionsMono(TextDocumentPositionParams param
 					}
 				}
 				list.setItems(items);
+				//This is a hack. It bypasses lsp4e filtering / sorting because it
+				// it behaves totally bonkers. See: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535823
+				// See also https://www.pivotaltracker.com/story/show/159667257
+				if (LspClient.currentClient()==Client.ECLIPSE) {
+					list.setIsIncomplete(true); 
+				}
 				return list;
 			})
 			.doOnNext(x -> log.info("Got {} completions", x.getItems().size()))