Migrate tests from JUnit 3 to JUnit 5 [SWF-1739]

[spring-operator]

Rossen Stoyanchev opened SWF-1739 and commented

Currently Web Flow's own tests still depend on the JUnit 3 class hierarchy and could be migrated to JUnit 5.

---

Affects: 2.5.1

Issue Links:

• Stop depending on JUnit 3 and upgrade to JUnit 4 [SWF-1738] #913 Stop depending on JUnit 3 and upgrade to JUnit 4
  ("is duplicated by")

1 votes, 3 watchers

[spring-operator]

Rossen Stoyanchev commented

Related PR #97 with migration to JUnit 4.

[spring-operator]

Sam Brannen commented

FYI: I used the following two shell scripts to migrate the test suite for the Spring Framework.

• https://github.com/sbrannen/junit-converters/blob/master/junit3ToJUnit4.zsh
• https://github.com/sbrannen/junit-converters/blob/master/junit4ToJUnitJupiter.zsh

[spring-operator]

Sam Brannen commented

Related to #915

[spring-operator]

Etienne Dysli Metref commented

I used sed to migrate. ;)
What makes jumping from 3 to 5 tricky is that the message argument of assertion methods moved from the first to the last position. Instances of assertEquals still compile, but are incorrect.

[spring-operator]

Etienne Dysli Metref commented

Changes to migrate to JUnit 5 are ready for review in PR#99. I'm looking forward to your comments. :)