Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fix to convert @Autowired field into constructor param doesn't work #1183

Closed
martinlippert opened this issue Feb 5, 2024 · 3 comments
Closed

quick fix to convert @Autowired field into constructor param doesn't work #1183

martinlippert opened this issue Feb 5, 2024 · 3 comments
Assignees
@BoykoAlex
Labels
for: eclipse something that is specific for Eclipse theme: refactoring theme: validation type: bug
Milestone
4.21.1.RELEASE

Comments

@martinlippert
Copy link
Member

The quick fix to convert an @Autowired field into a constructor param doesn't work anymore. It just doesn't happen anytime after selecting the quick fix. There is nothing showing up in the Error Log and there is nothing showing up in the language server log. It just doesn't happen anything.

Tested on the latest 4.21.1 release candidate for Eclipse.
@martinlippert martinlippert added this to the 4.21.1.RELEASE milestone Feb 5, 2024
@martinlippert martinlippert changed the title quick fix to convert @lAutowired field into constructor param doesn't work quick fix to convert @Autowired field into constructor param doesn't work Feb 5, 2024
@BoykoAlex
Copy link
Contributor

This needs a fix in LSP4E and can be reproduce with the latest lsp4e snapshot or 0.24.7 release

@martinlippert
Copy link
Member Author

Corresponding activity in LSP4E at eclipse-lsp4e/lsp4e#908

@martinlippert
Copy link
Member Author

The fix got merged into LSP4E and will be included in the upcoming 4.21.1.RELEASE, therefore closing this here as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: eclipse something that is specific for Eclipse theme: refactoring theme: validation type: bug
Projects
None yet
Milestone
4.21.1.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex