Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve parser-based validation for SpEL snippets #1237

Closed
martinlippert opened this issue Apr 18, 2024 · 1 comment
Closed

improve parser-based validation for SpEL snippets #1237

martinlippert opened this issue Apr 18, 2024 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spel-support theme: validation type: enhancement

Comments

@martinlippert
Copy link
Member

At the moment, the validation logic for SpEL expressions is pretty simple using the standard SpEL parser that comes with Spring itself. If the parser reports a problem while parsing, this problem is reported as a diagnostic for the whole expression.

The goal is to use a more sophisticated diagnostics detection for SpEL expressions and report more fine grained and detailed diagnostics. Maybe we need to adopt an ANTLR-based parser for this (instead of the standard SpEL parser), but that depends on the features the parser offers for this more detailed diagnostics.

@martinlippert martinlippert added type: enhancement theme: spel-support for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation labels Apr 18, 2024
@martinlippert martinlippert added this to the 4.23.0.RELEASE milestone Apr 18, 2024
@BoykoAlex
Copy link
Contributor

Hopefully fixed with 15f20b6 exceptfor embedded inside SQL queries which is be addressed via #1270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spel-support theme: validation type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants