Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory with space(s) get its url encoded to %2520 #2

Open
ghost opened this issue Aug 21, 2017 · 0 comments
Open

Directory with space(s) get its url encoded to %2520 #2

ghost opened this issue Aug 21, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 21, 2017

Version: 1.1.0

Steps to reproduce:

  1. Create a directory and give it a name containing one or more spaces.
  2. Open it
  3. You'll find the following bugs:
    3.1. If the directory contains another directory with space(s), it will fail to load if you try to open it. The parent directory's url path will get its space(s) encoded to %2520.
    3.2. Navigating using the breadcrumb__directory link (either with subdir or not) results in the same bug. Looking at the source, the spaces also get converted to %2520.

Expected:

  1. The % character in %20 should not be encoded to %25.
  2. Improvement: encode all spaces in the url with %20 or +.
  3. Improvement: keep the spaces in the breadcrumb__directory link text.
@ghost ghost changed the title Directory with space(s) got its url encoded to %2520 Directory with space(s) get its url encoded to %2520 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants