Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XHR withCredentials maybe? #4

Open
davidgfnet opened this issue Nov 18, 2019 · 0 comments
Open

XHR withCredentials maybe? #4

davidgfnet opened this issue Nov 18, 2019 · 0 comments

Comments

@davidgfnet
Copy link

Hey there!
I'm using this with some authentication on top of it (like SSO), that means the XHR request needs cookies to work.
I just added .withCredentials = true; which seems reasonably safe as a default in the code.
Would you take such change? I can send a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidgfnet