Skip to content

Commit 84b45e9

Browse files
committed
code review
1 parent 2a18a66 commit 84b45e9

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

springdoc-openapi-common/src/main/java/org/springdoc/api/AbstractOpenApiResource.java

+12-8
Original file line numberDiff line numberDiff line change
@@ -836,8 +836,9 @@ protected Set<RequestMethod> getDefaultAllowedHttpMethods() {
836836
* @return the operation
837837
*/
838838
protected Operation customizeOperation(Operation operation, HandlerMethod handlerMethod) {
839-
if (springDocCustomizers.getOperationCustomizers().isPresent()) {
840-
List<OperationCustomizer> operationCustomizerList = springDocCustomizers.getOperationCustomizers().get();
839+
Optional<List<OperationCustomizer>> optionalOperationCustomizers = springDocCustomizers.getOperationCustomizers();
840+
if (optionalOperationCustomizers.isPresent()) {
841+
List<OperationCustomizer> operationCustomizerList = optionalOperationCustomizers.get();
841842
for (OperationCustomizer operationCustomizer : operationCustomizerList)
842843
operation = operationCustomizer.customize(operation, handlerMethod);
843844
}
@@ -846,13 +847,15 @@ protected Operation customizeOperation(Operation operation, HandlerMethod handle
846847

847848
/**
848849
* Customise router operation
849-
* @param routerOperation
850-
* @param handlerMethod
850+
*
851+
* @param routerOperation the router operation
852+
* @param handlerMethod the handler method
851853
* @return the router operation
852854
*/
853855
protected RouterOperation customizeRouterOperation(RouterOperation routerOperation, HandlerMethod handlerMethod) {
854-
if (springDocCustomizers.getRouterOperationCustomizers().isPresent()) {
855-
List<RouterOperationCustomizer> routerOperationCustomizerList = springDocCustomizers.getRouterOperationCustomizers().get();
856+
Optional<List<RouterOperationCustomizer>> optionalRouterOperationCustomizers = springDocCustomizers.getRouterOperationCustomizers();
857+
if (optionalRouterOperationCustomizers.isPresent()) {
858+
List<RouterOperationCustomizer> routerOperationCustomizerList = optionalRouterOperationCustomizers.get();
856859
for (RouterOperationCustomizer routerOperationCustomizer : routerOperationCustomizerList) {
857860
routerOperation = routerOperationCustomizer.customize(routerOperation, handlerMethod);
858861
}
@@ -1356,8 +1359,9 @@ enum ConditionType {
13561359
* @return the router operation
13571360
*/
13581361
private RouterOperation customizeDataRestRouterOperation(RouterOperation routerOperation) {
1359-
if (springDocCustomizers.getDataRestRouterOperationCustomizers().isPresent()) {
1360-
List<DataRestRouterOperationCustomizer> dataRestRouterOperationCustomizerList = springDocCustomizers.getDataRestRouterOperationCustomizers().get();
1362+
Optional<List<DataRestRouterOperationCustomizer>> optionalDataRestRouterOperationCustomizers = springDocCustomizers.getDataRestRouterOperationCustomizers();
1363+
if (optionalDataRestRouterOperationCustomizers.isPresent()) {
1364+
List<DataRestRouterOperationCustomizer> dataRestRouterOperationCustomizerList = optionalDataRestRouterOperationCustomizers.get();
13611365
for (DataRestRouterOperationCustomizer dataRestRouterOperationCustomizer : dataRestRouterOperationCustomizerList) {
13621366
routerOperation = dataRestRouterOperationCustomizer.customize(routerOperation);
13631367
}

0 commit comments

Comments
 (0)